Extract generic form of resource force-refresh logic #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to kubernetes-el#69. This PR extracts the core of the resource-specific `kubernetes-<resource>-refresh-now` functions into the resource-generic `kubernetes-state--refresh-now` function. This function represents the "core" of the function template used to generate the resource-specific force-refresh functions. This PR leaves the resource-specific refresh-now functions in place, re-implementing them as wrappers around the new resource-generic version. The resource-specific functions have test coverage, which provides a vote of confidence as to the safety of this change. We'll leave sunsetting of the resource-specific functions' use to subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #69.
This PR extracts the core of the resource-specific
kubernetes-<resource>-refresh-nowfunctions into the resource-generickubernetes-state--refresh-nowfunction. This function represents the "core" ofthe function template used to generate the resource-specific force-refresh
functions.
This PR leaves the resource-specific refresh-now functions in place,
re-implementing them as wrappers around the new resource-generic version. The
resource-specific functions have test coverage, which provides a vote of
confidence as to the safety of this change. We'll leave sunsetting of the
resource-specific functions' use to subsequent PRs.