Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

NAT gateway tagging #1063

Closed
mumoshu opened this issue Dec 7, 2017 · 5 comments
Closed

NAT gateway tagging #1063

mumoshu opened this issue Dec 7, 2017 · 5 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mumoshu
Copy link
Contributor

mumoshu commented Dec 7, 2017

The CloudFormation release of September 27, 2017 adds the support for tagging "AWS::EC2::NatGateway".
For consistency with other AWS resources managed by kube-aws, NAT gateways should also be tagged with kubernetes.io/cluster/{{.ClusterName}}.

Ref: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.html
@mumoshu mumoshu added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 7, 2017
@cknowles cknowles mentioned this issue Feb 8, 2018
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2019
@vsamidurai vsamidurai mentioned this issue May 19, 2019
Merged
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 22, 2019
@vsamidurai
Copy link
Contributor

issue has been fixed in #1596

@vsamidurai
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@vsamidurai: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mumoshu @k8s-ci-robot @vsamidurai @fejta-bot