This repository has been archived by the owner on Oct 30, 2019. It is now read-only.
Add timestamp to all reports #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
|
k8s-ci-robot
added
the
cncf-cla: no
|
fixes: #12 |
k8s-ci-robot
added
cncf-cla: yes
Currently, the `timestamp` field is only added to reports that are processed with a Spartakus collector. If you run the volunteer with `--database=stdout` or even `--database=bigquery://...` your records will have no timestamp. This commit adds the timestamp field to reports at the time of creation in the volunteer.
|
LGTM |
thockin
reviewed
Dec 1, 2016
| @@ -89,7 +88,6 @@ func (s *APIServer) storeRecordHandler() httprouter.Handle { | |||
| writeError(w, http.StatusBadRequest, fmt.Errorf("failed to decode record: %v", err)) | |||
| return | |||
| } | |||
| rec.Timestamp = strconv.FormatInt(time.Now().Unix(), 10) | |||
There was a problem hiding this comment.
I did this on purpose, to add some modicum of sanity to the data, but I guess it doesn't matter much.
There was a problem hiding this comment.
what do you mean by sanity?
|
sanity: I know it's not total garbage :) But since the whole report is
voluntary, it could all be garbage, so probably moot.
…On Wed, Nov 30, 2016 at 9:03 PM, Brandon Philips ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/collector/api.go
<#13>:
> @@ -89,7 +88,6 @@ func (s *APIServer) storeRecordHandler() httprouter.Handle {
writeError(w, http.StatusBadRequest, fmt.Errorf("failed to decode record: %v", err))
return
}
- rec.Timestamp = strconv.FormatInt(time.Now().Unix(), 10)
what do you mean by sanity?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AFVgVO3lGCGaJJBL1fJ2B7iWADjY3yvhks5rDlU6gaJpZM4K6HnB>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
timestampfield is only added to reports that areprocessed with a Spartakus collector. If you run the volunteer with
--database=stdoutor even--database=bigquery://...your recordswill have no timestamp. This commit adds the timestamp field to reports
at the time of creation in the volunteer.