Merge pull request #618 from kubernetes-sigs/disable-attacher

feat: disable attacher by default
kubernetes-sigs · Apr 16, 2021 · 50ff8a4 · 50ff8a4
2 parents 6c633b0 + f362593
commit 50ff8a4
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 2 deletions.
diff --git a/charts/README.md b/charts/README.md
@@ -63,6 +63,7 @@ The following table lists the configurable parameters of the latest Azure File C
 | `controller.replicas`                             | the replicas of csi-azurefile-controller                    | 2                                                                 |
 | `controller.metricsPort`                          | metrics port of csi-azurefile-controller                   |29614                                                        |
 | `controller.runOnMaster`                          | run controller on master node                                                          |`false`                                                           |
+| `controller.attachRequired`                       | enable attach/detach (only valid for vhd disk feature)                                            |`false`                                                           |
 | `controller.logLevel`                             | controller driver log level                                                          |`5`                                                           |
 | `node.metricsPort`                                | metrics port of csi-azurefile-node                         |29615                                                        |
 | `node.logLevel`                                   | node driver log level                                                          |`5`                                                           |

diff --git a/charts/latest/azurefile-csi-driver-v1.2.0.tgz b/charts/latest/azurefile-csi-driver-v1.2.0.tgz
diff --git a/charts/latest/azurefile-csi-driver/templates/csi-azurefile-driver.yaml b/charts/latest/azurefile-csi-driver/templates/csi-azurefile-driver.yaml
@@ -4,5 +4,5 @@ kind: CSIDriver
 metadata:
   name: file.csi.azure.com
 spec:
-  attachRequired: true
+  attachRequired: {{ .Values.controller.attachRequired }}
   podInfoOnMount: true
diff --git a/charts/latest/azurefile-csi-driver/values.yaml b/charts/latest/azurefile-csi-driver/values.yaml
@@ -34,6 +34,7 @@ controller:
   replicas: 2
   metricsPort: 29614
   runOnMaster: false
+  attachRequired: false
   logLevel: 5
 
 node:

diff --git a/deploy/csi-azurefile-driver.yaml b/deploy/csi-azurefile-driver.yaml
@@ -4,5 +4,5 @@ kind: CSIDriver
 metadata:
   name: file.csi.azure.com
 spec:
-  attachRequired: true
+  attachRequired: false
   podInfoOnMount: true