Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mountOptions e2e test #138

Closed
andyzhangx opened this issue Dec 1, 2019 · 4 comments · Fixed by #346
Closed

add mountOptions e2e test #138

andyzhangx opened this issue Dec 1, 2019 · 4 comments · Fixed by #346
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/test

Comments

@andyzhangx
Copy link
Member

andyzhangx commented Dec 1, 2019

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

including

negative tests are done:

ginkgo.It("should receive FailedMount event with invalid mount options [file.csi.azure.com] [disk]", func() {
skipIfUsingInTreeVolumePlugin()
skipIfTestingInWindowsCluster()
pods := []testsuites.PodDetails{
{
Cmd: "echo 'hello world' > /mnt/test-1/data && grep 'hello world' /mnt/test-1/data",
Volumes: []testsuites.VolumeDetails{
{
ClaimSize: "10Gi",
MountOptions: []string{
"invalid",
"mount",
"options",
},
VolumeMount: testsuites.VolumeMountDetails{
NameGenerate: "test-volume-",
MountPathGenerate: "/mnt/test-",
},
},
},
},
}
test := testsuites.DynamicallyProvisionedInvalidMountOptions{
CSIDriver: testDriver,
Pods: pods,
StorageClassParameters: map[string]string{"skuName": "Premium_LRS", "fsType": "ext4"},
}
test.Run(cs, ns)

Describe alternatives you've considered

Additional context

@andyzhangx andyzhangx added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/test labels Dec 1, 2019
levimm pushed a commit to levimm/azurefile-csi-driver that referenced this issue Dec 25, 2019
@bcho
Copy link
Contributor

bcho commented Dec 27, 2019

I am working on this issue cc @andyzhangx

/assign @bcho

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 11, 2020
@andyzhangx
Copy link
Member Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 12, 2020
azure file driver project automation moved this from To do to Done Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/test
Projects
Development

Successfully merging a pull request may close this issue.

4 participants