Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support using existing azure file share in storage class #59

Closed
andyzhangx opened this issue Apr 21, 2019 · 4 comments · Fixed by #70
Closed

support using existing azure file share in storage class #59

andyzhangx opened this issue Apr 21, 2019 · 4 comments · Fixed by #70
Assignees
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@andyzhangx
Copy link
Member

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

scenario is like this:
https://github.com/csi-driver/blobfuse-csi-driver#option1-use-existing-credentials-in-k8s-cluster

Need to add a new parameter(shareName) in azure file storage class, and create an azure file if it does not exist:

retAccount, _, err := d.cloud.CreateFileShare(fileShareName, account, sku, accountKind, resourceGroup, location, requestGiB)

Describe alternatives you've considered

Additional context

/assign

@ashishranjan738
Copy link
Contributor

I think i can take this up

@andyzhangx andyzhangx added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 21, 2019
@andyzhangx
Copy link
Member Author

it's not a urgent feature, let me change the interface in azure cloud provider first since currently it still uses func (s *Share) Create(options *FileRequestOptions) other than func (s *Share) CreateIfNotExists(options *FileRequestOptions) func

@lenisha
Copy link

lenisha commented Apr 22, 2019

we have a scenario to mount azure files using the cluster identity or secrets coming from Vault

@andyzhangx
Copy link
Member Author

The PR(kubernetes/kubernetes#77042) is already merged in v1.14.2, upgrade to use that lib and a few code change could make this feature work.

RomanBednar pushed a commit to RomanBednar/azurefile-csi-driver that referenced this issue Apr 11, 2024
…ncy-openshift-4.16-azure-file-csi-driver

OCPBUGS-31869: Updating ose-azure-file-csi-driver-container image to be consistent with ART for 4.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants