Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure the VolumeSnapshots v1 CRDs exist before starting #1258

Merged
merged 1 commit into from
May 15, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented May 14, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: make sure the VolumeSnapshots v1 CRDs exist before starting
related to fix: kubernetes-csi/external-snapshotter#505

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: make sure the VolumeSnapshots v1 CRDs exist before starting

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cvvz and gnufied May 14, 2023 09:43
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2023
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx changed the title fix: snapshot controller crash issue when CRDs are not ready fix: make sure the VolumeSnapshots v1 CRDs exist before starting May 15, 2023
@andyzhangx andyzhangx merged commit 2ba4f82 into master May 15, 2023
33 of 34 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.27

@k8s-infra-cherrypick-robot

@andyzhangx: #1258 failed to apply on top of branch "release-1.27":

Applying: fix: snapshot controller crash issue when CRDs are not ready
Using index info to reconstruct a base tree...
A	charts/latest/azurefile-csi-driver-v0.0.0.tgz
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): charts/latest/azurefile-csi-driver-v0.0.0.tgz deleted in HEAD and modified in fix: snapshot controller crash issue when CRDs are not ready. Version fix: snapshot controller crash issue when CRDs are not ready of charts/latest/azurefile-csi-driver-v0.0.0.tgz left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: snapshot controller crash issue when CRDs are not ready
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants