Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MSI-enabled cluster for e2e test #165

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Use MSI-enabled cluster for e2e test #165

merged 2 commits into from
Feb 19, 2020

Conversation

chewong
Copy link
Member

@chewong chewong commented Feb 12, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #163 (comment)

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2020
@chewong
Copy link
Member Author

chewong commented Feb 12, 2020

/assign @andyzhangx

@chewong chewong mentioned this pull request Feb 12, 2020
Merged
@andyzhangx andyzhangx added this to In progress in azure file driver project Feb 14, 2020
@andyzhangx
Copy link
Member

I think we should add another test config:

  • sp with vmas
  • msi with vmss

andyzhangx
andyzhangx reviewed Feb 14, 2020
View reviewed changes
test/e2e/manifest/linux.json Outdated
@@ -6,8 +6,9 @@
"orchestratorType": "Kubernetes",
"orchestratorRelease": "1.16",
"kubernetesConfig": {
"useManagedIdentity": true,
"userAssignedID": "azurefile-csi-driver-e2e-test-id",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you configure azurefile-csi-driver-e2e-test-id identity somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will create a new identity named azurefile-csi-driver-e2e-test-id every time. Currently, aks-engine does not support the use of existing identity during cluster creation so we are relying on kubetest to assign "Owner" permission to the identity before running the test.

@chewong
Copy link
Member Author

chewong commented Feb 18, 2020

I think we should add another test config:

  • sp with vmas
  • msi with vmss

SGTM

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2020
andyzhangx
andyzhangx approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
@chewong could you also add a new PR in test-infra for linux-vmss.json config? thanks.

azure file driver project automation moved this from In progress to Reviewer approved Feb 19, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, chewong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit a5009e1 into kubernetes-sigs:master Feb 19, 2020
azure file driver project automation moved this from Reviewer approved to Done Feb 19, 2020
@chewong chewong deleted the msi branch February 19, 2020 17:18
@chewong chewong mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
azure file driver project
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chewong @andyzhangx @k8s-ci-robot