Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cluster driver registrar #231

Merged
merged 1 commit into from Apr 4, 2020

Conversation

ZeroMagic
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
According to Kubernetes CSI Developer Documentation, the cluster-driver-registrar side-car which was used to create CSIDriver objects in Kubernetes 1.13 has been deprecated for Kubernetes 1.16. No cluster-driver-registrar has been released for Kubernetes 1.14 and later.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

remove cluster driver registrar

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ZeroMagic
To complete the pull request process, please assign andyzhangx
You can assign the PR to them by writing /assign @andyzhangx in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 3, 2020
@andyzhangx
Copy link
Member

could you make sure this PR works in k8s 1.14? There are quite a lot users are using 1.14 now, we need to make sure it works. thanks @ZeroMagic

Signed-off-by: ZeroMagic <jiliu8@microsoft.com>
@andyzhangx
Copy link
Member

/test pull-azurefile-csi-driver-e2e-windows

@andyzhangx andyzhangx merged commit 4b20a48 into kubernetes-sigs:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants