-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add version command and ldflags #27
Conversation
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
using the doom font > bom doom |
@cpanato: My friend told me that pepper is the best seasoning for a roast, but I took it with a grain of salt. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpanato -- Approving to move this along, but...
I feel like we write a version
package/version for multiple projects. Could we abstract/de-dupe?
Consider writing this as a package in sigs.k8s.io/release-utils that can be an importable cobra.Command
.
See https://github.com/kubernetes/enhancements/tree/master/pkg/kepctl/commands for an example, as well @n3wscott's comments in kubernetes/enhancements#2387 (review) for more background.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Created kubernetes-sigs/release-utils#23 to discuss. |
GitHub reviews should act as /lgtm |
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
to help in debug and inform the user which version they are using
/assign @puerco @justaugustus @xmudrii @Verolop @saschagrunert
cc @kubernetes-sigs/release-engineering
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?