Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub PR reviews act as /lgtm + /approve for SIG Release repos #1464

Closed
justaugustus opened this issue Feb 15, 2021 · 3 comments · Fixed by kubernetes/test-infra#20934
Closed

GitHub PR reviews act as /lgtm + /approve for SIG Release repos #1464

justaugustus opened this issue Feb 15, 2021 · 3 comments · Fixed by kubernetes/test-infra#20934
Assignees
@supriya-premkumar
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
SIG Release
Milestone
v1.21

Comments

@justaugustus
Copy link
Member

What would you like to be added:

From kubernetes/test-infra#20819 (comment):

@kubernetes/sig-release-leads -- How would y'all feel about making this change for SIG Release repos as well?

Let's follow Aaron and SIG Testing's lead and turn this on for SIG Release repos.

Use:

Why is this needed:

Easy review/approval workflow.
(Further outlined in https://groups.google.com/g/kubernetes-sig-testing/c/gumjq2guMa0.)

cc: @kubernetes/release-engineering
/help
/milestone v1.21
/priority important-soon
@justaugustus justaugustus added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 15, 2021
@justaugustus justaugustus added this to Backlog in SIG Release via automation Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 15, 2021
@justaugustus justaugustus mentioned this issue Feb 15, 2021
Merged
@supriya-premkumar
Copy link

I can take this one up.

@saschagrunert
Copy link
Member

@supriya-premkumar this is awesome, feel free to reach out anytime if there is anything unclear.

/assign @supriya-premkumar
/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 17, 2021
@dims
Copy link
Member

dims commented Feb 20, 2021

@supriya-premkumar as mentioned on slack the following

the list of repositories under sig-release management can be found here:
https://github.com/kubernetes/community/tree/master/sig-release#release-engineering

supriya-premkumar pushed a commit to supriya-premkumar/test-infra that referenced this issue Feb 21, 2021
Standardizes lgtm/approve workflows for sig-release
78d903f 
Changes:
	1. Adds the following repos to lgtm and approve plugins.
	   - kubernetes-sigs/downloadkubernetes
	   - kubernetes-sigs/k8s-container-image-promoter
	   - kubernetes-sigs/mdtoc
	   - kubernetes-sigs/release-notes
	   - kubernetes-sigs/zeitgeist
	   - kubernetes/publishing-bot
	   - kubernetes/release
	   - kubernetes/sig-release
	2. Fixes kubernetes/sig-release#1464
@supriya-premkumar supriya-premkumar mentioned this issue Feb 21, 2021
Merged
supriya-premkumar added a commit to supriya-premkumar/test-infra that referenced this issue Feb 21, 2021
@supriya-premkumar
Standardizes lgtm/approve workflows for sig-release
a847e3a 
Changes:
	1. Adds the following repos to lgtm and approve plugins.
	   - kubernetes-sigs/downloadkubernetes
	   - kubernetes-sigs/k8s-container-image-promoter
	   - kubernetes-sigs/mdtoc
	   - kubernetes-sigs/release-notes
	   - kubernetes-sigs/zeitgeist
	   - kubernetes/publishing-bot
	   - kubernetes/release
	   - kubernetes/sig-release
	2. Fixes kubernetes/sig-release#1464
supriya-premkumar added a commit to supriya-premkumar/test-infra that referenced this issue Feb 21, 2021
@supriya-premkumar
Standardizes lgtm/approve workflows for sig-release
74978d3 
Changes:
	1. Adds the following repos to lgtm and approve plugins.
	   - kubernetes-sigs/downloadkubernetes
	   - kubernetes-sigs/k8s-container-image-promoter
	   - kubernetes-sigs/mdtoc
	   - kubernetes-sigs/release-notes
	   - kubernetes-sigs/zeitgeist
	   - kubernetes/publishing-bot
	   - kubernetes/release
	   - kubernetes/sig-release
	2. Fixes kubernetes/sig-release#1464
@justaugustus justaugustus moved this from Backlog to In Review in SIG Release Feb 23, 2021
@LappleApple LappleApple moved this from In Review to Done/Closed (1.21) in SIG Release Mar 9, 2021
This was referenced Jan 22, 2022
Merged
Closed
@xmudrii xmudrii mentioned this issue Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supriya-premkumar supriya-premkumar

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
No open projects
SIG Release
  
Done/Closed
Milestone
v1.21
Development

Successfully merging a pull request may close this issue.

Standardizes lgtm/approve workflows for sig-release supriya-premkumar/test-infra
5 participants
@dims @justaugustus @saschagrunert @supriya-premkumar @k8s-ci-robot