Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardizes lgtm/approve workflows for sig-release #20934

Merged

Conversation

supriya-premkumar
Copy link
Contributor

Changes:

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 21, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @supriya-premkumar!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @supriya-premkumar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/config Issues or PRs related to code in /config size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 21, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 21, 2021
@dims
Copy link
Member

dims commented Feb 21, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2021
@dims
Copy link
Member

dims commented Feb 21, 2021

/assign @justaugustus @saschagrunert

@dims
Copy link
Member

dims commented Feb 21, 2021

nice work @supriya-premkumar .. thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2021
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this, @supriya-premkumar!
I've got one microscopic nit (that the list of repos should be alpha-sorted) and I've left fixes as code suggestions. :)

config/prow/plugins.yaml Outdated Show resolved Hide resolved
config/prow/plugins.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2021
Changes:
	1. Adds the following repos to lgtm and approve plugins.
	   - kubernetes-sigs/downloadkubernetes
	   - kubernetes-sigs/k8s-container-image-promoter
	   - kubernetes-sigs/mdtoc
	   - kubernetes-sigs/release-notes
	   - kubernetes-sigs/zeitgeist
	   - kubernetes/publishing-bot
	   - kubernetes/release
	   - kubernetes/sig-release
	2. Fixes kubernetes/sig-release#1464
@justaugustus
Copy link
Member

Thanks again!
/lgtm
/approve

Over to @dims for the /approve on config/!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2021
@dims
Copy link
Member

dims commented Feb 22, 2021

/approve
/hold

@justaugustus feel free to remove hold when appropriate (need to notify folks via email?)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, supriya-premkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2021
@dims
Copy link
Member

dims commented Mar 1, 2021

/hold cancel

it's been a week!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2021
@justaugustus
Copy link
Member

@dims -- Apologies for not dropping the hold! This was discussed and approved on last week's SIG Release meeting.

@supriya-premkumar -- Thanks again for this awesome contribution!

cc: @kubernetes/sig-release-leads
/test pull-test-infra-integration

@k8s-ci-robot k8s-ci-robot merged commit 24e8093 into kubernetes:master Mar 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 1, 2021
@k8s-ci-robot
Copy link
Contributor

@supriya-premkumar: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Changes:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@supriya-premkumar
Copy link
Contributor Author

@dims -- Apologies for not dropping the hold! This was discussed and approved on last week's SIG Release meeting.

@supriya-premkumar -- Thanks again for this awesome contribution!

cc: @kubernetes/sig-release-leads
/test pull-test-infra-integration

Thank you @dims and @justaugustus. This is my first contribution to K8s repo that got merged. It feels surreal ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub PR reviews act as /lgtm + /approve for SIG Release repos
5 participants