New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardizes lgtm/approve workflows for sig-release #20934
Standardizes lgtm/approve workflows for sig-release #20934
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @supriya-premkumar! |
Hi @supriya-premkumar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
78d903f
to
a847e3a
Compare
/ok-to-test |
/assign @justaugustus @saschagrunert |
nice work @supriya-premkumar .. thanks! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for working on this, @supriya-premkumar!
I've got one microscopic nit (that the list of repos should be alpha-sorted) and I've left fixes as code suggestions. :)
Changes: 1. Adds the following repos to lgtm and approve plugins. - kubernetes-sigs/downloadkubernetes - kubernetes-sigs/k8s-container-image-promoter - kubernetes-sigs/mdtoc - kubernetes-sigs/release-notes - kubernetes-sigs/zeitgeist - kubernetes/publishing-bot - kubernetes/release - kubernetes/sig-release 2. Fixes kubernetes/sig-release#1464
a847e3a
to
74978d3
Compare
Thanks again! Over to @dims for the |
/approve @justaugustus feel free to remove hold when appropriate (need to notify folks via email?) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, justaugustus, supriya-premkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel it's been a week! |
@dims -- Apologies for not dropping the hold! This was discussed and approved on last week's SIG Release meeting. @supriya-premkumar -- Thanks again for this awesome contribution! cc: @kubernetes/sig-release-leads |
@supriya-premkumar: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thank you @dims and @justaugustus. This is my first contribution to K8s repo that got merged. It feels surreal ❤️ |
Changes: