Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace zones flag with additional filter #90

Closed
wants to merge 1 commit into from
Closed

Replace zones flag with additional filter #90

wants to merge 1 commit into from

Conversation

azylinski
Copy link

Fix WARNING:

Flag --zones is deprecated. Use --filter="zone:( ZONE ... )" instead.
For example --filter="zone:( europe-west1-b europe-west1-c )".

@azylinski
Replace zones flag with additional filter
27a6975 
Fix WARNING:

Flag `--zones` is deprecated. Use `--filter="zone:( ZONE ... )"` instead.
For example `--filter="zone:( europe-west1-b europe-west1-c )"`.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azylinski
To complete the pull request process, please assign ixdy after the PR has been reviewed.
You can assign the PR to them by writing /assign @ixdy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @azylinski!

It looks like this is your first PR to kubernetes-sigs/boskos 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/boskos has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @azylinski. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2021
alvaroaleman
alvaroaleman reviewed Jul 7, 2021
View reviewed changes
Copy link
Member

@alvaroaleman alvaroaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to Jeff, I am not really familiar with the janitors
/ok-to-test
/uncc

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2021
ixdy
ixdy reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@ixdy ixdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this change locally? Our automated testing doesn't really test the janitor.

Does this work with all resource types? I'm concerned whether there are any that only support --zones and not specifying the zone in the filter.

/ok-to-test

cmd/janitor/gcp_janitor.py
if resource.condition == 'zone' and resource.name not in ['sole-tenancy', 'network-endpoint-groups']:
if len(filt) > 0:
filt.append(' AND ')
filt.append('zone=(%s)' % ','.join(ZONES))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these supposed to be comma-separated or space-separated?

cmd/janitor/gcp_janitor.py
@@ -256,14 +256,17 @@ def collect(project, age, resource, filt, clear_all):
if resource.name == 'sinks' and not clear_all:
return col

if resource.condition == 'zone' and resource.name not in ['sole-tenancy', 'network-endpoint-groups']:
if len(filt) > 0:
filt.append(' AND ')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't filt a string? don't you want += here (and the next line)?

@ixdy
Copy link
Contributor

ixdy commented Jul 20, 2021

/cc @chemikadze

@k8s-ci-robot
Copy link
Contributor

@ixdy: GitHub didn't allow me to request PR reviews from the following users: chemikadze.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @chemikadze

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy
Copy link
Contributor

ixdy commented Aug 10, 2021

/close

I think this was obsoleted by #98.

@k8s-ci-robot
Copy link
Contributor

@ixdy: Closed this PR.

In response to this:

/close

I think this was obsoleted by #98.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman left review comments

@ixdy ixdy ixdy left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azylinski @k8s-ci-robot @ixdy @alvaroaleman