Merge pull request #3768 from nilo19/chore/sku

chore: set default loadBalancerSKU to Standard
kubernetes-sigs · Apr 20, 2023 · 8eb0d6a · 8eb0d6a
2 parents 9291c6d + 2b14601
commit 8eb0d6a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/pkg/provider/azure.go b/pkg/provider/azure.go
@@ -706,6 +706,10 @@ func (az *Cloud) initCaches() (err error) {
 }
 
 func (az *Cloud) setLBDefaults(config *Config) error {
+	if config.LoadBalancerSku == "" {
+		config.LoadBalancerSku = consts.LoadBalancerSkuStandard
+	}
+
 	if strings.EqualFold(config.LoadBalancerSku, consts.LoadBalancerSkuStandard) {
 		// Do not add master nodes to standard LB by default.
 		if config.ExcludeMasterFromStandardLB == nil {

diff --git a/pkg/provider/azure_test.go b/pkg/provider/azure_test.go
@@ -3917,3 +3917,13 @@ func TestFindSecurityRule(t *testing.T) {
 		assert.Equal(t, testCases[i].expected, found, testCases[i].desc)
 	}
 }
+
+func TestSetLBDefaults(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+	az := GetTestCloud(ctrl)
+
+	config := &Config{}
+	_ = az.setLBDefaults(config)
+	assert.Equal(t, config.LoadBalancerSku, consts.LoadBalancerSkuStandard)
+}