Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set default loadBalancerSKU to Standard #3768

Merged
merged 1 commit into from Apr 20, 2023

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Apr 20, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

ClusterConfig defaults loadBalancerSku to basic: https://cloud-provider-azure.sigs.k8s.io/install/configs/#cluster-config.

On 30 September 2025, Basic SKU public IP addresses will be retired in Azure. You can continue to use your existing Basic SKU public IP addresses until then, however, you'll no longer be able to create new ones after 31 March 2025.

Basic SKU is being retired. We should not be defaulting to basic for LB and public IP SKUs.

Standard SKU public IP addresses offer significant improvements, including:

  • Access to a variety of other Azure products, including Standard Load Balancer, Azure Firewall, and NAT Gateway.
  • Security by default—closed to inbound flows unless allowed by a network security group.
  • Zone-redundant and zonal front ends for inbound and outbound traffic.

Even if the retirement date is 3 years away, we should consider making this change now as the default value should reflect the recommended best practices in Azure.

Which issue(s) this PR fixes:

Fixes #2414

Special notes for your reviewer:

Does this PR introduce a user-facing change?

chore: set default loadBalancerSKU to Standard

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 20, 2023
@netlify
Copy link

netlify bot commented Apr 20, 2023

Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name Link
🔨 Latest commit 2b14601
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/644133e33aa7cc0008735136
😎 Deploy Preview https://deploy-preview-3768--kubernetes-sigs-cloud-provide-azure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2023
@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8eb0d6a into kubernetes-sigs:master Apr 20, 2023
19 checks passed
@nilo19 nilo19 deleted the chore/sku branch April 21, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoadBalancerSku should default to Standard
3 participants