Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA of acr-credential-provider #3116

Closed
feiskyer opened this issue Jan 13, 2023 · 2 comments · Fixed by #3756
Closed

GA of acr-credential-provider #3116

feiskyer opened this issue Jan 13, 2023 · 2 comments · Fixed by #3756
Assignees
@andyzhangx @ZeroMagic
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v1.27

Comments

@feiskyer
Copy link
Member

feiskyer commented Jan 13, 2023 •
edited by andyzhangx

What would you like to be added:

Per https://kubernetes.io/blog/2022/12/22/kubelet-credential-providers/, kubelet credential provider has been GA since v1.26 and the API version has been promoted to credentialprovider.kubelet.k8s.io/v1. For GA of acr-credential-provider, we need to

  • Upgrade the API version to credentialprovider.kubelet.k8s.io/v1
  • Enable the kubelet plugin in capz and enable e2e tests

Why is this needed:

https://cloud-provider-azure.sigs.k8s.io/topics/credential-provider/
@feiskyer feiskyer added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 13, 2023
@feiskyer feiskyer added this to the v1.27 milestone Jan 13, 2023
@andyzhangx
Copy link
Member

/assign

@andyzhangx
Copy link
Member

/assign @ZeroMagic

@andyzhangx andyzhangx mentioned this issue Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyzhangx andyzhangx

@ZeroMagic ZeroMagic

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v1.27
Development

Successfully merging a pull request may close this issue.

chore: upgrade credentialprovider-api-version to v1 andyzhangx/cloud-provider-azure
3 participants
@feiskyer @andyzhangx @ZeroMagic