Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade credentialprovider-api-version to v1 #3756

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Apr 19, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

chore: upgrade credentialprovider-api-version to v1

Per https://kubernetes.io/blog/2022/12/22/kubelet-credential-providers/, kubelet credential provider has been GA since v1.26 and the API version has been promoted to credentialprovider.kubelet.k8s.io/v1. For GA of acr-credential-provider, we need to

  • Upgrade the API version to credentialprovider.kubelet.k8s.io/v1

Which issue(s) this PR fixes:

Fixes #3116

Special notes for your reviewer:

I have also manually verified on 1.26 node with following feature flag and config, external credential provider works, next will set up e2e test:

,KubeletCredentialProviders=true --image-credential-provider-bin-dir=/var/lib/kubelet/credential-provider --image-credential-provider-config=/var/lib/kubelet/credential-provider-config.yaml
 
# vi credential-provider-config.yaml
kind: CredentialProviderConfig
apiVersion: kubelet.config.k8s.io/v1
providers:
- name: acr-credential-provider
  apiVersion: credentialprovider.kubelet.k8s.io/v1
  defaultCacheDuration: 10m
  matchImages:
  - "*.azurecr.io"
  - "*.azurecr.cn"
  - "*.azurecr.de"
  - "*.azurecr.us"
  args:
  - /etc/kubernetes/azure.json

Does this PR introduce a user-facing change?

chore: upgrade credentialprovider-api-version to v1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

chore: upgrade credentialprovider-api-version to v1

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2023
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name Link
🔨 Latest commit 70833d8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/643ffbe81aa574000860de9e
😎 Deploy Preview https://deploy-preview-3756--kubernetes-sigs-cloud-provide-azure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jwtty April 19, 2023 08:35
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2023
chore: add cmd change for credentialprovider api-version upgrade

fix goimport lint
@andyzhangx andyzhangx force-pushed the upgrade-credentialprovider-api-version branch from 23f8c79 to a634b52 Compare April 19, 2023 08:50
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8862664 into kubernetes-sigs:master Apr 20, 2023
20 checks passed
@lzhecheng
Copy link
Contributor

/cherrypick release-1.26

@k8s-infra-cherrypick-robot

@lzhecheng: #3756 failed to apply on top of branch "release-1.26":

Applying: chore: upgrade credentialprovider-api-version to v1
Applying: doc: update credentialprovider doc
Using index info to reconstruct a base tree...
A	site/content/en/topics/credential-provider.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): site/content/en/topics/credential-provider.md deleted in HEAD and modified in doc: update credentialprovider doc. Version doc: update credentialprovider doc of site/content/en/topics/credential-provider.md left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 doc: update credentialprovider doc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GA of acr-credential-provider
5 participants