New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade credentialprovider-api-version to v1 #3756
chore: upgrade credentialprovider-api-version to v1 #3756
Conversation
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chore: add cmd change for credentialprovider api-version upgrade fix goimport lint
23f8c79
to
a634b52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see this!
/lgtm
/cherrypick release-1.26 |
@lzhecheng: #3756 failed to apply on top of branch "release-1.26":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
chore: upgrade credentialprovider-api-version to v1
Per https://kubernetes.io/blog/2022/12/22/kubelet-credential-providers/, kubelet credential provider has been GA since v1.26 and the API version has been promoted to
credentialprovider.kubelet.k8s.io/v1
. For GA of acr-credential-provider, we need tocredentialprovider.kubelet.k8s.io/v1
Which issue(s) this PR fixes:
Fixes #3116
Special notes for your reviewer:
I have also manually verified on 1.26 node with following feature flag and config, external credential provider works, next will set up e2e test:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: