Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not update tags on load balancer, security group and route ta… #1006

Merged
merged 1 commit into from Jan 18, 2022
Merged

fix: do not update tags on load balancer, security group and route ta… #1006

merged 1 commit into from Jan 18, 2022

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jan 18, 2022

…ble if both tags and tagsMap are empty

(cherry picked from commit 58d4a02)

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: do not update tags on load balancer, security group and route table if both tags and tagsMap are empty

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@nilo19
fix: do not update tags on load balancer, security group and route ta…
6650de9 
…ble if both tags and tagsMap are empty

(cherry picked from commit 58d4a02)
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@nilo19
Copy link
Contributor Author

nilo19 commented Jan 18, 2022

/retest

@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit b4a4191 into kubernetes-sigs:release-1.0 Jan 18, 2022
@nilo19 nilo19 deleted the fix/cherry-pick-1004-1.0 branch January 19, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nilo19 @k8s-ci-robot @MartinForReal