Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boilerplate checking #106

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Add boilerplate checking #106

merged 1 commit into from
Mar 7, 2019

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Mar 7, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind cleanup

What this PR does / why we need it:

Add boilerplate checking and moving scritps into hack dir.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 7, 2019
@feiskyer feiskyer added this to In progress in Provider Azure Mar 7, 2019
@feiskyer
Copy link
Member Author

feiskyer commented Mar 7, 2019

/test pull-cloud-provider-azure-e2e

@feiskyer
Copy link
Member Author

feiskyer commented Mar 7, 2019

/assign @andyzhangx

@andyzhangx andyzhangx mentioned this pull request Mar 7, 2019
Closed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
andyzhangx
andyzhangx approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyzhangx,feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3e76d59 into kubernetes-sigs:master Mar 7, 2019
Provider Azure automation moved this from In progress to Done Mar 7, 2019
@feiskyer feiskyer deleted the hack branch March 7, 2019 13:59
@andyzhangx andyzhangx mentioned this pull request Mar 10, 2019
Closed
This was referenced Mar 26, 2019
Closed
Closed
@mrbobbytables mrbobbytables removed this from Done in Provider Azure Nov 4, 2019
JoelSpeed pushed a commit to JoelSpeed/cloud-provider-azure that referenced this pull request Mar 1, 2024
@openshift-merge-bot
Merge pull request kubernetes-sigs#106 from JoelSpeed/concurrent-syncs
6d07b28 
OCPBUGS-29012: Remove concurrent-service-syncs limitation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@feiskyer @k8s-ci-robot @andyzhangx