Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] Cherry pick of #1070 to release-1.23 #1097

Merged
merged 2 commits into from Jan 31, 2022
Merged

[release-1.23] Cherry pick of #1070 to release-1.23 #1097

merged 2 commits into from Jan 31, 2022

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jan 30, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cherry pick of #1070 to release-1.23:

fix: use zones in the pre-existing frontend IP configurations for internal LBs
chore: bump network api version from 2020-08-01 to 2021-02-01

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: use zones in the pre-existing frontend IP configurations for internal LBs

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 30, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 80.123% when pulling 4709a36 on nilo19:fix/cherry-pick-1070-1.23 into 85c186d on kubernetes-sigs:release-1.23.

feiskyer
feiskyer approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nilo19
Copy link
Contributor Author

nilo19 commented Jan 31, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit b80bb39 into kubernetes-sigs:release-1.23 Jan 31, 2022
@nilo19 nilo19 deleted the fix/cherry-pick-1070-1.23 branch January 31, 2022 14:56
@nilo19 nilo19 mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilo19 @coveralls @k8s-ci-robot @feiskyer