Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] Fix: enable public access if sourceRange is specified when lb is in internal mode #1122

Merged
merged 1 commit into from Feb 9, 2022
Merged

[release-1.1] Fix: enable public access if sourceRange is specified when lb is in internal mode #1122

merged 1 commit into from Feb 9, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1109

/assign MartinForReal

if spec.LoadBalancerSourceRanges is specified and lb is in internal mode, LB is open for public access.(close by default for security reasons)

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 9, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 9, 2022
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.795% when pulling 346b126 on k8s-infra-cherrypick-robot:cherry-pick-1109-to-release-1.1 into 1b8cd14 on kubernetes-sigs:release-1.1.

@MartinForReal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@MartinForReal
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7cd3f79 into kubernetes-sigs:release-1.1 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @coveralls @MartinForReal @k8s-ci-robot