Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.1]Fix: health probe config should be port-specific #1128

Merged
merged 2 commits into from Feb 14, 2022
Merged

[release-1.1]Fix: health probe config should be port-specific #1128

merged 2 commits into from Feb 14, 2022

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Feb 10, 2022

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #949 #948

Special notes for your reviewer:

Please pay special attention to changes in loadbanalcer_test.go since it may introduce break change.

Does this PR introduce a user-facing change?


Following  configuration will be applied to the all ports of service.

"service.beta.kubernetes.io/azure-load-balancer-health-probe-protocol"
"service.beta.kubernetes.io/azure-load-balancer-health-probe-interval"
"service.beta.kubernetes.io/azure-load-balancer-health-probe-num-of-probe"
"service.beta.kubernetes.io/azure-load-balancer-health-probe-request-path"

If health probe is needed, user should specify AppProtocol in port object of Service spec.
And following protocols are supported: http, tcp, https

Additional annotations are added. where port is the port number of port object

service.beta.kubernetes.io/port_{port}_health-probe_interval
service.beta.kubernetes.io/port_{port}_health-probe_num-of-probe
service.beta.kubernetes.io/port_{port}_health-probe_request-path

Please refer to docs.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Signed-off-by: Shangxiang Fan <shafan@microsoft.com>
Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@MartinForReal MartinForReal changed the title Release 1.1/backport pr963 [release-1.1]Fix: health probe config should be port-specific Feb 10, 2022
@coveralls
Copy link

coveralls commented Feb 10, 2022

Coverage Status

Coverage increased (+0.04%) to 80.832% when pulling e869e96 on MartinForReal:release-1.1/backport_pr963 into 7cd3f79 on kubernetes-sigs:release-1.1.

Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@MartinForReal
Copy link
Contributor Author

/assign @feiskyer

@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2022
@MartinForReal
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-22

@k8s-ci-robot k8s-ci-robot merged commit ef39d20 into kubernetes-sigs:release-1.1 Feb 14, 2022
@MartinForReal MartinForReal deleted the release-1.1/backport_pr963 branch February 15, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants