Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] Fix bugs related to multiple slbs #1299

Merged
merged 2 commits into from Mar 21, 2022
Merged

[release-1.0] Fix bugs related to multiple slbs #1299

merged 2 commits into from Mar 21, 2022

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Mar 21, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cherry pick of #1289 to release-1.0: Fix bugs related to multiple slbs

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: remove agent pool LB if that vmSet is changed to primary vmSet
fix: reuse previous private IP address when changing load balancers

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2022
@MartinForReal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MartinForReal,nilo19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@nilo19
Copy link
Contributor Author

nilo19 commented Mar 21, 2022

/retest

1 similar comment
@nilo19
Copy link
Contributor Author

nilo19 commented Mar 21, 2022

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Mar 21, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-21

@k8s-ci-robot k8s-ci-robot merged commit 20625f7 into kubernetes-sigs:release-1.0 Mar 21, 2022
@nilo19 nilo19 deleted the fix/cherry-pick-1289-1.0 branch March 22, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nilo19 @MartinForReal @k8s-ci-robot