Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.1] fix: only check the frontend IP config that is owned by the service #1320

Merged
merged 1 commit into from Mar 24, 2022
Merged

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Mar 24, 2022

(cherry picked from commit c12a25c)

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cherry pick of #1315 to release-1.1: fix: only check the frontend IP config that is owned by the service

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: only check the frontend IP config that is owned by the service

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 80.828% when pulling 5652100 on nilo19:fix/cherry-pick-1315-1.1 into 23a46ee on kubernetes-sigs:release-1.1.

@nilo19 nilo19 changed the title fix: only check the frontend IP config that is owned by the service [release-1.1] fix: only check the frontend IP config that is owned by the service Mar 24, 2022
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@nilo19
Copy link
Contributor Author

nilo19 commented Mar 24, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-1-22

@nilo19
Copy link
Contributor Author

nilo19 commented Mar 24, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit ac4b9fc into kubernetes-sigs:release-1.1 Mar 24, 2022
@nilo19 nilo19 deleted the fix/cherry-pick-1315-1.1 branch March 25, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants