Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] Reduce listPIP calls #1546

Merged
merged 1 commit into from Apr 22, 2022
Merged

[release-1.23] Reduce listPIP calls #1546

merged 1 commit into from Apr 22, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1500

/assign MartinForReal

Reduce ListPublicIPAddress call count by avoiding each call in loops

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 22, 2022
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 80.392% when pulling eef341f on k8s-infra-cherrypick-robot:cherry-pick-1500-to-release-1.23 into 73cf6a7 on kubernetes-sigs:release-1.23.

@MartinForReal
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 22, 2022
@MartinForReal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@MartinForReal
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-vmss-1-23

@k8s-ci-robot k8s-ci-robot merged commit 75c9a86 into kubernetes-sigs:release-1.23 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @coveralls @MartinForReal @k8s-ci-robot @jwtty