Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: update k8s dependencies to 1.24 #1655

Merged
merged 1 commit into from May 6, 2022
Merged

Feature: update k8s dependencies to 1.24 #1655

merged 1 commit into from May 6, 2022

Conversation

MartinForReal
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update dependencies to 1.24

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nilo19 May 5, 2022 02:04
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 5, 2022
@coveralls
Copy link

coveralls commented May 5, 2022 •
edited

Coverage Status

Coverage decreased (-0.01%) to 80.475% when pulling 15fae1a on MartinForReal:feat/upgrade-t0-1.24 into 0b76f09 on kubernetes-sigs:master.

@MartinForReal
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss

@MartinForReal
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb

@MartinForReal
Copy link
Contributor Author

/override pull-cloud-provider-azure-check

@k8s-ci-robot
Copy link
Contributor

@MartinForReal: Overrode contexts on behalf of MartinForReal: pull-cloud-provider-azure-check

In response to this:

/override pull-cloud-provider-azure-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MartinForReal
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb

@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@jwtty
Copy link
Member

jwtty commented May 5, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss

@k8s-ci-robot k8s-ci-robot merged commit 8820284 into kubernetes-sigs:master May 6, 2022
@MartinForReal MartinForReal deleted the feat/upgrade-t0-1.24 branch May 6, 2022 01:24
seung-moon added a commit to seung-moon/cloud-provider-azure that referenced this pull request May 15, 2022
@seung-moon
Revert "Merge pull request kubernetes-sigs#1655 from MartinForReal/fe…
2975a43 
…at/upgrade-t0-1.24"

This reverts commit 8820284, reversing
changes made to e7b035b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MartinForReal @k8s-ci-robot @coveralls @lzhecheng @jwtty