feat(load-balancer): support specifying Public IP address prefix to produce IP of Load Balancer

[zarvd]

What type of PR is this?

/feat

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

A new annotation is added in order to specify the PublicIP Prefix for creating IP of LB

service.beta.kubernetes.io/azure-pip-prefix-id: "/subscriptions/8ecadfc9-ffff-4ea4-ffff-0d9f87e4d7c8/resourceGroups/lodrem/providers/Microsoft.Network/publicIPPrefixes/bb"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @lodrem. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Coverage decreased (-0.04%) to 80.289% when pulling 355614c on lodrem:feat/support-pip-prefix into 8283086 on kubernetes-sigs:master.

[feiskyer]

/kind feature
/ok-to-test

[feiskyer]

@lodrem could you fix the unit test failures?

[nilo19]

minor concern: will it be good to use name instead of id to keep aligned with the ServiceAnnotationPIPName?

[zarvd]

Is ID more specific and clear? Because it requires the full path id to create a PIP.

[feiskyer]

I think id is more general. Adding prefix-name would also need another prefix-resource-group, and maybe also its subscription, hence three annotations would be needed instead of one.

[nilo19]

can we enrich the release note to state the public-facing changes?

[nilo19]

Is it allowed for both the IP and IPPrefixID annotations exist at a time?

[zarvd]

can we enrich the release note to state the public-facing changes?

sure

Is it allowed for both the IP and IPPrefixID annotations exist at a time?

It will handle the pip-name first. If both of them are specified, then it creates by pip-name.

[nilo19]

/lgtm

[feiskyer]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lodrem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

/cherrypick release-1.24

[k8s-infra-cherrypick-robot]

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.24 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feiskyer]

/cherrypick release-1.23

[k8s-infra-cherrypick-robot]

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feiskyer]

/cherrypick release-1.1

[k8s-infra-cherrypick-robot]

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feiskyer]

/cherrypick release-1.0

[k8s-infra-cherrypick-robot]

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@feiskyer: new pull request created: #1848

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@feiskyer: #1828 failed to apply on top of branch "release-1.23":

Applying: Support Public IP Prefix for creating Public IP
Applying: Fix E2E test case
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	site/content/en/topics/loadbalancer.md
M	tests/e2e/network/ensureloadbalancer.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/ensureloadbalancer.go
Auto-merging site/content/en/topics/loadbalancer.md
CONFLICT (content): Merge conflict in site/content/en/topics/loadbalancer.md
Auto-merging pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix E2E test case
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@feiskyer: #1828 failed to apply on top of branch "release-1.1":

Applying: Support Public IP Prefix for creating Public IP
Applying: Fix E2E test case
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	site/content/en/topics/loadbalancer.md
M	tests/e2e/network/ensureloadbalancer.go
M	tests/e2e/network/service_annotations.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/service_annotations.go
Auto-merging tests/e2e/network/ensureloadbalancer.go
Auto-merging site/content/en/topics/loadbalancer.md
CONFLICT (content): Merge conflict in site/content/en/topics/loadbalancer.md
Auto-merging pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix E2E test case
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@feiskyer: #1828 failed to apply on top of branch "release-1.0":

Applying: Support Public IP Prefix for creating Public IP
Applying: Fix E2E test case
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	site/content/en/topics/loadbalancer.md
M	tests/e2e/network/ensureloadbalancer.go
M	tests/e2e/network/service_annotations.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/service_annotations.go
Auto-merging tests/e2e/network/ensureloadbalancer.go
Auto-merging site/content/en/topics/loadbalancer.md
CONFLICT (content): Merge conflict in site/content/en/topics/loadbalancer.md
Auto-merging pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix E2E test case
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.