Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] feat(load-balancer): support specifying Public IP address prefix to produce IP of Load Balancer #1857

Merged
merged 4 commits into from Jun 19, 2022
Merged

[release-1.1] feat(load-balancer): support specifying Public IP address prefix to produce IP of Load Balancer #1857

merged 4 commits into from Jun 19, 2022

Conversation

zarvd
Copy link
Contributor

@zarvd zarvd commented Jun 16, 2022

What type of PR is this?

/feat

What this PR does / why we need it:

cherry-pick #1828 to release-1.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

A new annotation is added in order to specify the PublicIP Prefix for creating IP of LB

service.beta.kubernetes.io/azure-pip-prefix-id: "/subscriptions/8ecadfc9-ffff-4ea4-ffff-0d9f87e4d7c8/resourceGroups/lodrem/providers/Microsoft.Network/publicIPPrefixes/bb"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lodrem. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2022
@coveralls
Copy link

coveralls commented Jun 16, 2022 •
edited

Coverage Status

Coverage decreased (-0.04%) to 80.628% when pulling 23778ff on lodrem:feat/support-pip-prefix-for-release-1.1 into 8866a0b on kubernetes-sigs:release-1.1.

feiskyer
feiskyer approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/kind bug
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/needs-kind labels Jun 17, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lodrem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@feiskyer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@zarvd zarvd force-pushed the feat/support-pip-prefix-for-release-1.1 branch from 29a113a to 23778ff Compare June 17, 2022 07:11
@lzhecheng
Copy link
Contributor

/retest

1 similar comment
@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/retest

@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2022
@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/retest

1 similar comment
@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/retest

@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/test pull-cloud-provider-azure-e2e-ccm-capz-1-22

@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/retest

@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-22

1 similar comment
@jwtty
Copy link
Member

jwtty commented Jun 19, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb-1-22

@k8s-ci-robot k8s-ci-robot merged commit 987d91e into kubernetes-sigs:release-1.1 Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@feiskyer feiskyer

@jwtty jwtty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zarvd @k8s-ci-robot @coveralls @feiskyer @lzhecheng @jwtty