fix: make sure there is no duplicated rules before updating the netwo… #1998
Conversation
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
✅ Deploy Preview for warm-cascaron-bb779f canceled.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/retest |
|
/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb |
pkg/provider/azure_utils.go
Outdated
| klog.Warningf("Found duplicated rule %s, will be removed.", to.String(rules[i].Name)) | ||
| rules = append(rules[:i], rules[i+1:]...) | ||
| } else { | ||
| ruleNames[to.String(rules[i].Name)] = true |
There was a problem hiding this comment.
I prefer not put this line in else. Fewer indention.
pkg/provider/azure_utils_test.go
Outdated
| t.Run(testCase.description, func(t *testing.T) { | ||
| rules := testCase.rules | ||
| rules = removeDuplicatedSecurityRules(rules) | ||
| assert.Equal(t, testCase.expected, rules, testCase.description) |
There was a problem hiding this comment.
I prefer no testCase.description here since L310 already includes it.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…rk security group
k8s-ci-robot
removed
the
lgtm
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/cherrypick release-1.0 |
|
/cherrypick release-1.1 |
|
/cherrypick release-1.23 |
|
/cherrypick release-1.24 |
|
@nilo19: new pull request created: #2004 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nilo19: new pull request created: #2005 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nilo19: new pull request created: #2006 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nilo19: new pull request created: #2007 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…rk security group
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Make sure there is no duplicated rules before updating the network security group.
Which issue(s) this PR fixes:
Fixes #1829
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: