Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a single transport to reuse connections, fix performance issues and enable tracing #2059

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Jul 20, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1567

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Create a single transport to reuse connections, address performance issues and enable tracing.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2022
@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for warm-cascaron-bb779f canceled.

Name Link
🔨 Latest commit 8af9772
🔍 Latest deploy log https://app.netlify.com/sites/warm-cascaron-bb779f/deploys/62d76d80d6f85c00095cabed

@netlify
Copy link

netlify bot commented Jul 20, 2022

Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 8af9772
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/62d76d80e7f7270008c22f88

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@coveralls
Copy link

coveralls commented Jul 20, 2022

Coverage Status

Coverage increased (+0.02%) to 79.828% when pulling 8af9772 on MartinForReal:master into 8ffd413 on kubernetes-sigs:master.

}).DialContext,
ForceAttemptHTTP2: true,
MaxIdleConns: 100,
MaxConnsPerHost: 100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the default values of these numbers, could you add a comment with a link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the comments.

Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@MartinForReal
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MartinForReal,andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MartinForReal
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-capz


@k8s-ci-robot k8s-ci-robot merged commit 64d5fad into kubernetes-sigs:master Jul 21, 2022
@feiskyer
Copy link
Member

@MartinForReal cherrypick to release branches?

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.24

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.23

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.1

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.0

@k8s-infra-cherrypick-robot

@MartinForReal: new pull request created: #2071

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@MartinForReal: #2059 failed to apply on top of branch "release-1.23":

Applying: create a single transport to reuse connections and enable tracing
Using index info to reconstruct a base tree...
M	go.mod
M	pkg/azureclients/armclient/azure_armclient.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azureclients/armclient/azure_armclient.go
CONFLICT (content): Merge conflict in pkg/azureclients/armclient/azure_armclient.go
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 create a single transport to reuse connections and enable tracing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@MartinForReal: #2059 failed to apply on top of branch "release-1.1":

Applying: create a single transport to reuse connections and enable tracing
Using index info to reconstruct a base tree...
M	go.mod
M	pkg/azureclients/armclient/azure_armclient.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azureclients/armclient/azure_armclient.go
CONFLICT (content): Merge conflict in pkg/azureclients/armclient/azure_armclient.go
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 create a single transport to reuse connections and enable tracing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@MartinForReal: #2059 failed to apply on top of branch "release-1.0":

Applying: create a single transport to reuse connections and enable tracing
Using index info to reconstruct a base tree...
M	go.mod
M	pkg/azureclients/armclient/azure_armclient.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azureclients/armclient/azure_armclient.go
CONFLICT (content): Merge conflict in pkg/azureclients/armclient/azure_armclient.go
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 create a single transport to reuse connections and enable tracing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants