fix: don't set vm entry as nil in cache when vm is in Deleting state to avoid VMSSList throttling #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
✅ Deploy Preview for warm-cascaron-bb779f canceled.
|
k8s-ci-robot
added
the
size/XS
andyzhangx
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Coverage increased (+0.004%) to 79.808% when pulling 5272185bab3739d696c919183b657ec40da0002d on andyzhangx:deleting-set-nil-issue into 8ffd413 on kubernetes-sigs:master. |
|
/assign @nilo19 @MartinForReal |
andyzhangx
force-pushed
the
deleting-set-nil-issue
branch
from
5272185
to
a1027fb
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: don't set vm entry as nil in cache when vm is in Deleting state to avoid VMSSList throttling
When VM is in Deleting state, original behavior is setting as nil, and then with this PR(#1578), Deleting state VM will be not found in cache, then it would trigger VMSSList again, found VM is still in Deleting state, return nil, trigger VMSSList again and again, finally get VMSSList throttling.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: