fix: Do not retry regional when request is not GET

[jwtty]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Only check response body length when request is GET.

Which issue(s) this PR fixes:

related #2296

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Only check response body length when request is GET. Avoids unnecessary retry when deleting an LB.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[netlify]

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name	Link
🔨 Latest commit	5a8d98d
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/632f32dd33e24b000826392e

[coveralls]

Coverage decreased (-0.02%) to 80.305% when pulling 5a8d98d on jwtty:retry into 07f8572 on kubernetes-sigs:master.

[jwtty]

/test pull-cloud-provider-azure-e2e-capz

[MartinForReal]

send function accept decorator as parameters and maybe we can move DoHackRegionalRetryDecorator to GetResource function ?

[feiskyer]

send function accept decorator as parameters and maybe we can move DoHackRegionalRetryDecorator to GetResource function ?

yes, this is another way to achieve the same goal. Which approach do you prefer?

[MartinForReal]

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz

[MartinForReal]

LGTM

[feiskyer]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, jwtty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feiskyer,jwtty]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

/cherrypick release-1.1

[k8s-infra-cherrypick-robot]

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feiskyer]

/cherrypick release-1.23

[feiskyer]

/cherrypick release-1.24

[feiskyer]

/cherrypick release-1.25

[k8s-infra-cherrypick-robot]

@feiskyer: #2363 failed to apply on top of branch "release-1.1":

Applying: Do not retry regional when request is not GET
Using index info to reconstruct a base tree...
M	pkg/azureclients/armclient/azure_armclient.go
M	pkg/azureclients/armclient/azure_armclient_test.go
A	pkg/azureclients/armclient/util.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/azureclients/armclient/util.go deleted in HEAD and modified in Do not retry regional when request is not GET. Version Do not retry regional when request is not GET of pkg/azureclients/armclient/util.go left in tree.
Auto-merging pkg/azureclients/armclient/azure_armclient_test.go
Auto-merging pkg/azureclients/armclient/azure_armclient.go
CONFLICT (content): Merge conflict in pkg/azureclients/armclient/azure_armclient.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Do not retry regional when request is not GET
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@feiskyer: #2363 failed to apply on top of branch "release-1.23":

Applying: Do not retry regional when request is not GET
Using index info to reconstruct a base tree...
M	pkg/azureclients/armclient/azure_armclient.go
M	pkg/azureclients/armclient/azure_armclient_test.go
A	pkg/azureclients/armclient/util.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/azureclients/armclient/util.go deleted in HEAD and modified in Do not retry regional when request is not GET. Version Do not retry regional when request is not GET of pkg/azureclients/armclient/util.go left in tree.
Auto-merging pkg/azureclients/armclient/azure_armclient_test.go
Auto-merging pkg/azureclients/armclient/azure_armclient.go
CONFLICT (content): Merge conflict in pkg/azureclients/armclient/azure_armclient.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Do not retry regional when request is not GET
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@feiskyer: new pull request created: #2389

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@feiskyer: new pull request created: #2390

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.