Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.25] fix: Do not retry regional when request is not GET #2390

Merged
merged 1 commit into from Sep 26, 2022
Merged

[release-1.25] fix: Do not retry regional when request is not GET #2390

merged 1 commit into from Sep 26, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2363

/assign feiskyer

Only check response body length when request is GET. Avoids unnecessary retry when deleting an LB.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 25, 2022
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 80.301% when pulling 0a2c691 on k8s-infra-cherrypick-robot:cherry-pick-2363-to-release-1.25 into da81192 on kubernetes-sigs:release-1.25.

feiskyer
feiskyer reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind labels Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit eaaa0a6 into kubernetes-sigs:release-1.25 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @coveralls @k8s-ci-robot @feiskyer @jwtty