Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.25] fix: Skip VMSS VM update operations if the VMs are not in good state #2401

Merged
merged 1 commit into from Sep 28, 2022
Merged

[release-1.25] fix: Skip VMSS VM update operations if the VMs are not in good state #2401

merged 1 commit into from Sep 28, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2386

/assign nilo19

fix: Skip VMSS VM update operations if the VMs are not in good state
fix: Set the retryAfter to 5s when PUT failed due to concurrent operation conflict.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 27, 2022
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 80.355% when pulling c0a6b04 on k8s-infra-cherrypick-robot:cherry-pick-2386-to-release-1.25 into 833b4dc on kubernetes-sigs:release-1.25.

@nilo19
Copy link
Contributor

nilo19 commented Sep 27, 2022

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
@nilo19 nilo19 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5913ff2 into kubernetes-sigs:release-1.25 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@jwtty jwtty Awaiting requested review from jwtty

Assignees

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @coveralls @nilo19 @k8s-ci-robot