Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add part of e2e tests for cloud-config and ServiceAnnotationLoadBalancerMode #2405

Closed
wants to merge 1 commit into from
Closed

add part of e2e tests for cloud-config and ServiceAnnotationLoadBalancerMode #2405

wants to merge 1 commit into from

Conversation

lanlou1554
Copy link
Contributor

@lanlou1554 lanlou1554 commented Sep 27, 2022 •
edited

What type of PR is this?

/kind testing

What this PR does / why we need it:

Make it possible to change the value of cloud-config in e2e tests.
Add part of missing tests for cloud-config and service annotation "service.beta.kubernetes.io/azure-load-balancer-mode":

  1. Tags, TagsMap, SystemTags
  2. EnableMultipleStandardLoadBalancers
  3. PrimaryScaleSetName
  4. NodePoolsWithoutDedicatedSLB
  5. ServiceAnnotationLoadBalancerMode: loadBalancerSku is set to standard and "auto" value

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Cloud_util.go makes it possible to change the value of cloud-config in e2e tests.
Changes in service_annotation.go improve the test of "service.beta.kubernetes.io/azure-load-balancer-mode".
Cloud_config.go adds e2e tests for cloud-config.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/testing labels Sep 27, 2022
@netlify
Copy link

netlify bot commented Sep 27, 2022 •
edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit e034c12
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/633466cc4b93010008d601ce

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @monianshouhou. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 27, 2022
@lanlou1554
Copy link
Contributor Author

/assign @lzhecheng

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: monianshouhou
Once this PR has been reviewed and has the lgtm label, please ask for approval from lzhecheng by writing /assign @lzhecheng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Sep 27, 2022 •
edited

Coverage Status

Coverage remained the same at 80.218% when pulling e034c12 on monianshouhou:improve_e2e_coverage_3 into 65705cd on kubernetes-sigs:master.

@lanlou1554 lanlou1554 force-pushed the improve_e2e_coverage_3 branch 2 times, most recently from 2dc76f8 to c434e82 Compare September 27, 2022 10:11
@lzhecheng
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2022
@lanlou1554 lanlou1554 changed the title add part of missing tests for cloud-config and ServiceAnnotationLoadBalancerMode add part of tests for cloud-config and ServiceAnnotationLoadBalancerMode Sep 28, 2022
@lanlou1554 lanlou1554 changed the title add part of tests for cloud-config and ServiceAnnotationLoadBalancerMode add part of e2e tests for cloud-config and ServiceAnnotationLoadBalancerMode Sep 28, 2022
lzhecheng
lzhecheng reviewed Sep 28, 2022
View reviewed changes
tests/e2e/network/cloud_config.go Outdated Show resolved Hide resolved
tests/e2e/network/cloud_config.go Outdated Show resolved Hide resolved
tests/e2e/network/cloud_config.go Outdated Show resolved Hide resolved
tests/e2e/network/cloud_config.go Outdated Show resolved Hide resolved
tests/e2e/network/cloud_config.go Show resolved Hide resolved
tests/e2e/network/cloud_config.go Outdated Show resolved Hide resolved
tests/e2e/network/service_annotations.go Outdated Show resolved Hide resolved
tests/e2e/network/service_annotations.go Outdated Show resolved Hide resolved
tests/e2e/network/service_annotations.go Outdated Show resolved Hide resolved
tests/e2e/network/service_annotations.go Outdated
return backendPoolVMSSNames
}

func validateLoadBalancerBackendPools(tc *utils.AzureTestClient, vmssName string, cs clientset.Interface, serviceName string, labels map[string]string, ns string, ports []v1.ServicePort, resourceGroupName string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can move validateLoadBalancerBackendPools() above getVMSSNamesInLoadBalancerBackendPools then we will have less code change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@lanlou1554
Copy link
Contributor Author

/assign @feiskyer
PTAL.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2022
@k8s-ci-robot
Copy link
Contributor

@monianshouhou: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@monianshouhou: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-check e034c12 link true /test pull-cloud-provider-azure-check
pull-cloud-provider-azure-e2e-ccm-vmss-capz e034c12 link true /test pull-cloud-provider-azure-e2e-ccm-vmss-capz
pull-cloud-provider-azure-e2e-ccm-vmssflex-capz e034c12 link true /test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz
pull-cloud-provider-azure-e2e-ccm-capz e034c12 link true /test pull-cloud-provider-azure-e2e-ccm-capz
pull-cloud-provider-azure-unit e034c12 link true /test pull-cloud-provider-azure-unit
pull-cloud-provider-azure-e2e-capz e034c12 link true /test pull-cloud-provider-azure-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@feiskyer
Copy link
Member

Let's close this one as there are no updates for a long time.

/close

@k8s-ci-robot
Copy link
Contributor

@feiskyer: Closed this PR.

In response to this:

Let's close this one as there are no updates for a long time.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzhecheng lzhecheng lzhecheng left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@feiskyer feiskyer

@lzhecheng lzhecheng

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/testing needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lanlou1554 @k8s-ci-robot @coveralls @lzhecheng @feiskyer