feat: support snapshot with management api #2458

umagnus · 2022-10-09T07:36:08Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: support snapshot with management api

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: support snapshot with management api

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2022-10-09T07:36:16Z

Welcome @umagnus!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-10-09T07:36:17Z

Hi @umagnus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2022-10-09T07:36:25Z

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name	Link
🔨 Latest commit	`ec4057a`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/63579cade5f4ff0009904684

feiskyer · 2022-10-10T07:36:17Z

pkg/azureclients/fileclient/azure_fileclient.go

@@ -200,3 +200,74 @@ func (c *Client) GetServiceProperties(ctx context.Context, resourceGroupName, ac
 func (c *Client) SetServiceProperties(ctx context.Context, resourceGroupName, accountName string, parameters storage.FileServiceProperties) (storage.FileServiceProperties, error) {
 	return c.fileServicesClient.SetServiceProperties(ctx, resourceGroupName, accountName, parameters)
 }
+
+// CreateSnapshot creates a snapshot
+func (c *Client) CreateSnapshot(ctx context.Context, resourceGroupName, accountName string, shareOptions *ShareOptions) error {


Could you add some unit tests for those new functions?

We use old function CreateFileShare to support snapshot later.

feiskyer · 2022-10-10T07:36:35Z

/ok-to-test

coveralls · 2022-10-10T07:42:13Z

Coverage increased (+0.0009%) to 79.856% when pulling ec4057a on umagnus:snapshot into ccc0413 on kubernetes-sigs:master.

umagnus · 2022-10-17T06:54:16Z

/retest

umagnus · 2022-10-19T02:44:58Z

/retest

pkg/azureclients/fileclient/azure_fileclient.go

andyzhangx · 2022-10-20T08:37:27Z

pls also change the PR title and add release notes, it's not switch, it's support snapshot with management api

pkg/azureclients/fileclient/azure_fileclient.go

return FileShare in CreateSnapshot use fileshare instead of snapshot fix unittest add ListFileShare function add comment change ListFileShare function

andyzhangx

/lgtm
/approve

k8s-ci-robot · 2022-10-25T13:40:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, umagnus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andyzhangx · 2022-10-26T00:26:30Z

/retest

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2022

k8s-ci-robot requested review from jwtty and lzhecheng October 9, 2022 07:36

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2022

feiskyer reviewed Oct 10, 2022

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2022

umagnus force-pushed the snapshot branch from 7ec9e46 to 3a04c5a Compare October 19, 2022 01:58

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2022

umagnus force-pushed the snapshot branch from 3a04c5a to 1382688 Compare October 19, 2022 06:01

andyzhangx reviewed Oct 20, 2022

View reviewed changes

pkg/azureclients/fileclient/azure_fileclient.go Show resolved Hide resolved

pkg/azureclients/fileclient/azure_fileclient.go Show resolved Hide resolved

umagnus force-pushed the snapshot branch from 1382688 to 4cfe465 Compare October 21, 2022 04:17

umagnus changed the title ~~feat: switch azurefile snanshot to management api~~ feat: update to use management api for azure file snapshot Oct 21, 2022

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 21, 2022

umagnus changed the title ~~feat: update to use management api for azure file snapshot~~ feat: support snapshot with management api Oct 21, 2022

umagnus force-pushed the snapshot branch from 4cfe465 to 51b0a4c Compare October 21, 2022 04:29

k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 21, 2022

andyzhangx reviewed Oct 21, 2022

View reviewed changes

pkg/azureclients/fileclient/azure_fileclient.go Outdated Show resolved Hide resolved

umagnus force-pushed the snapshot branch from 51b0a4c to dd38835 Compare October 24, 2022 08:19

k8s-ci-robot added the do-not-merge/contains-merge-commits label Oct 25, 2022

switch azurefile snanshot to management api

ec4057a

return FileShare in CreateSnapshot use fileshare instead of snapshot fix unittest add ListFileShare function add comment change ListFileShare function

umagnus force-pushed the snapshot branch from 17dfe9f to ec4057a Compare October 25, 2022 08:22

k8s-ci-robot removed the do-not-merge/contains-merge-commits label Oct 25, 2022

andyzhangx approved these changes Oct 25, 2022

View reviewed changes

k8s-ci-robot assigned andyzhangx Oct 25, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2022

k8s-ci-robot merged commit d4e6529 into kubernetes-sigs:master Oct 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support snapshot with management api #2458

feat: support snapshot with management api #2458

umagnus commented Oct 9, 2022 •

edited

k8s-ci-robot commented Oct 9, 2022

k8s-ci-robot commented Oct 9, 2022

netlify bot commented Oct 9, 2022 •

edited

feiskyer Oct 10, 2022

umagnus Oct 21, 2022

feiskyer commented Oct 10, 2022

coveralls commented Oct 10, 2022 •

edited

umagnus commented Oct 17, 2022

umagnus commented Oct 19, 2022

andyzhangx commented Oct 20, 2022

andyzhangx left a comment

k8s-ci-robot commented Oct 25, 2022

andyzhangx commented Oct 26, 2022

feat: support snapshot with management api #2458

feat: support snapshot with management api #2458

Conversation

umagnus commented Oct 9, 2022 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Oct 9, 2022

k8s-ci-robot commented Oct 9, 2022

netlify bot commented Oct 9, 2022 • edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

feiskyer Oct 10, 2022

Choose a reason for hiding this comment

umagnus Oct 21, 2022

Choose a reason for hiding this comment

feiskyer commented Oct 10, 2022

coveralls commented Oct 10, 2022 • edited

umagnus commented Oct 17, 2022

umagnus commented Oct 19, 2022

andyzhangx commented Oct 20, 2022

andyzhangx left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 25, 2022

andyzhangx commented Oct 26, 2022

umagnus commented Oct 9, 2022 •

edited

netlify bot commented Oct 9, 2022 •

edited

coveralls commented Oct 10, 2022 •

edited