Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.1] Deprecate LoadBalancerIP with Servie LB IP annotation #2470

Merged
merged 1 commit into from Oct 11, 2022

Conversation

lzhecheng
Copy link
Contributor

  • Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6
  • Add an e2e test
  • Support retrieve Service CIDR in e2e framework

Signed-off-by: Zhecheng Li zhechengli@microsoft.com

What type of PR is this?

/kind cleanup
/kind feature
/kind deprecation

What this PR does / why we need it:

Deprecate LoadBalancerIP with Servie LB IP annotation

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Deprecate LoadBalancerIP with Servie LB IP annotation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 11, 2022
* Add service.beta.kubernetes.io/azure-load-balancer-ipv4
  and service.beta.kubernetes.io/azure-load-balancer-ipv6
* Add an e2e test
* Support retrieve Service CIDR in e2e framework

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 80.728% when pulling ccafeb5 on lzhecheng:cp-2428-r-1.1 into 50292d8 on kubernetes-sigs:release-1.1.

@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-22

@jwtty
Copy link
Member

jwtty commented Oct 11, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2d2b2ce into kubernetes-sigs:release-1.1 Oct 11, 2022
@lzhecheng lzhecheng deleted the cp-2428-r-1.1 branch February 17, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants