Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check internal lb ip in subnet before keeping it #2524

Merged
merged 1 commit into from Oct 14, 2022

Conversation

jwtty
Copy link
Member

@jwtty jwtty commented Oct 14, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Check internal lb ip in subnet before keeping it, so cx can change their lb subnet

Which issue(s) this PR fixes:

Fixes #2511

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Check internal lb ip in subnet before keeping it, so users can change their lb subnet.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2022
@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit f52eb17
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/6348f06c5769a9000938810e

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 79.926% when pulling f52eb17 on jwtty:subnet into e52a581 on kubernetes-sigs:master.

@jwtty
Copy link
Member Author

jwtty commented Oct 14, 2022

/test pull-cloud-provider-azure-e2e-capz

1 similar comment
@jwtty
Copy link
Member Author

jwtty commented Oct 14, 2022

/test pull-cloud-provider-azure-e2e-capz

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 927c153 into kubernetes-sigs:master Oct 14, 2022
@jwtty jwtty deleted the subnet branch October 15, 2022 06:45
@jwtty
Copy link
Member Author

jwtty commented Oct 15, 2022

/cherrypick release-1.25

@k8s-infra-cherrypick-robot

@jwtty: new pull request created: #2529

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwtty
Copy link
Member Author

jwtty commented Oct 15, 2022

/cherrypick release-1.24

@jwtty
Copy link
Member Author

jwtty commented Oct 15, 2022

/cherrypick release-1.23

@jwtty
Copy link
Member Author

jwtty commented Oct 15, 2022

/cherrypick release-1.1

@k8s-infra-cherrypick-robot

@jwtty: new pull request created: #2530

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@jwtty: new pull request created: #2531

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@jwtty: new pull request created: #2532

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILB frontend should select a new private IP when load-balancer-subnet is changed
5 participants