fix: check private dns zone before creation #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
k8s-ci-robot
added
the
size/S
ZeroMagic
force-pushed
the
private-dns-zone
branch
from
8030c6d
to
b1a3b5b
Compare
andyzhangx
reviewed
Nov 9, 2022
pkg/provider/azure_storageaccount.go
Outdated
| @@ -607,3 +613,13 @@ func isPrivateEndpointAsExpected(account storage.Account, accountOptions *Accoun | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
| func (az *Cloud) getPrivateDNSZone(ctx context.Context, vnetResourceGroup string) (privatedns.PrivateZone, *retry.Error) { | |||
| klog.V(2).Infof("Getting private dns zone(%s) in resourceGroup (%s)", PrivateDNSZoneName, vnetResourceGroup) | |||
There was a problem hiding this comment.
no need to print Getting private dns zone logs
There was a problem hiding this comment.
since there is only one line of code, I think it's better cancel this function, and use az.privatednsclient.Get directly.
pkg/provider/azure_storageaccount.go
Outdated
|
|
||
| func (az *Cloud) getVNetLink(ctx context.Context, vNetLinkName, vnetResourceGroup, vnetName string) (privatedns.VirtualNetworkLink, *retry.Error) { | ||
| klog.V(2).Infof("Getting virtual link for vnet(%s) and DNS Zone(%s) in resourceGroup(%s)", vNetLinkName, PrivateDNSZoneName, vnetResourceGroup) | ||
| return az.virtualNetworkLinksClient.Get(ctx, vnetResourceGroup, PrivateDNSZoneName, vNetLinkName) |
There was a problem hiding this comment.
cancel this function and use az.virtualNetworkLinksClient.Get in outer call
Signed-off-by: Ji An Liu <jiliu8@microsoft.com>
ZeroMagic
force-pushed
the
private-dns-zone
branch
from
b1a3b5b
to
a17afbc
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, ZeroMagic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We should add get PrivateDNSZone and get VNetLink to make this func idempotent, so that even creation return failed, it should succeeded in next try
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: