Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.25] fix public ip list call reduce #2808

Merged
merged 1 commit into from Nov 21, 2022
Merged

[release-1.25] fix public ip list call reduce #2808

merged 1 commit into from Nov 21, 2022

Conversation

jwtty
Copy link
Member

@jwtty jwtty commented Nov 21, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

Original pip = &pipList does not modify the passed slice actually.

Which issue(s) this PR fixes:

related #2707

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix to reduce PublicIPAddress list arm calls

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 80.414% when pulling c19b40c on jwtty:cp-pl-1.25 into eabff22 on kubernetes-sigs:release-1.25.

@jwtty
Copy link
Member Author

jwtty commented Nov 21, 2022

/test pull-cloud-provider-azure-e2e-capz-1-25

@nilo19 nilo19 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2022
@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit bdbb158 into kubernetes-sigs:release-1.25 Nov 21, 2022
@jwtty jwtty deleted the cp-pl-1.25 branch November 21, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jwtty @k8s-ci-robot @coveralls @MartinForReal @nilo19