Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resource group issue in disk attach #2817

Merged
merged 1 commit into from Nov 23, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: resource group issue in disk attach

Original behavior is using disk resource group as node resource group which is wrong, there would be issue when disk is not in node resource group, this PR fixes the issue.

resourceGroup, _, err := getInfoFromDiskURI(diskURI)
if err != nil {
return -1, err
}
return lun, vmset.WaitForUpdateResult(ctx, future, nodeName, resourceGroup, "attach_disk")

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: resource group issue in disk attach

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix: resource group issue in disk attach

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 23, 2022
@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 2fcc699
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/637e2f61a349710008597a10

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 23, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 79.596% when pulling 2fcc699 on andyzhangx:rg-issue into c905fb1 on kubernetes-sigs:master.

@mukhoakash
Copy link
Contributor

/lgtm
@andyzhangx I have written an e2e test case with similar changes to fix the resource group fix in the csi driver. I will discard by branch and test with your changes to verify that this issue gets covered in the csi driver e2e test.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit ad17551 into kubernetes-sigs:master Nov 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mukhoakash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mukhoakash
Copy link
Contributor

mukhoakash commented Nov 23, 2022

/lgtm @andyzhangx I have written an e2e test case with similar changes to fix the resource group fix in the csi driver. I will discard by branch and test with your changes to verify that this issue gets covered in the csi driver e2e test.

This was my change for reference: mukhoakash@f81141f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants