New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resource group issue in disk attach #2817
Conversation
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, mukhoakash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was my change for reference: mukhoakash@f81141f |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: resource group issue in disk attach
Original behavior is using disk resource group as node resource group which is wrong, there would be issue when disk is not in node resource group, this PR fixes the issue.
cloud-provider-azure/pkg/provider/azure_controller_common.go
Lines 270 to 274 in c905fb1
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: