feat: update cache support for starndard and vmss flex #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/retest |
k8s-ci-robot
added
the
needs-rebase
andyzhangx
force-pushed
the
update-cache-standard-flex2
branch
from
207d140
to
dd58e4d
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
refactor add more logging refine logging refine vmss DeleteCacheForNode refactor DeleteCacheForNode fix DeleteCacheForNode issue vmclient fix update vmssflex cache fix vmssflex cache update refine updateCache in WaitForUpdateResult fix ut fix refine logging test: add unit test for updateCache func revert fix golint fix
andyzhangx
force-pushed
the
update-cache-standard-flex2
branch
from
92459bf
to
f91eb41
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, ZeroMagic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nilo19
reviewed
Dec 21, 2022
| return err | ||
| } | ||
| // get sync.Map cache and remove the node from the cache | ||
| cacheKey := getVMSSVMCacheKey(node.resourceGroup, node.vmssName) | ||
| ss.lockMap.LockEntry(cacheKey) |
There was a problem hiding this comment.
It looks this PR introduces a race condition in the unit test: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cloud-provider-azure/2984/pull-cloud-provider-azure-unit/1605470798791839744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: update cache support for starndard and vmss flex
This PR is a preceding fix of #2608, also refines original update cache logic in VMSS
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: