Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support privateendpoint for blob-csi-driver #2992

Merged
merged 1 commit into from Dec 26, 2022
Merged

feat: Support privateendpoint for blob-csi-driver #2992

merged 1 commit into from Dec 26, 2022

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Dec 22, 2022 •
edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: Support private endpoint for blob-csi-driver

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cvvz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Dec 22, 2022 •
edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 5cd191a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/63a5c5598c273200083eefba

@cvvz cvvz changed the title feature: Support privateendpoint for blob-csi-driver feat: Support privateendpoint for blob-csi-driver Dec 22, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 22, 2022
@coveralls
Copy link

coveralls commented Dec 22, 2022 •
edited

Coverage Status

Coverage: 79.368% (-0.01%) from 79.378% when pulling 5cd191a on cvvz:support-privateendpoint into de80029 on kubernetes-sigs:master.

andyzhangx
andyzhangx reviewed Dec 23, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 23, 2022
@cvvz
Squashed commit of the following:
5cd191a 
commit e423f17
Merge: 0434a17 de80029
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Dec 23 15:04:04 2022 +0000

    Merge branch 'master' of github.com:kubernetes-sigs/cloud-provider-azure into support-privateendpoint

commit 0434a17
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Dec 23 06:22:22 2022 +0000

    fix

commit d77bb95
Author: weizhichen <weizhichen@microsoft.com>
Date:   Thu Dec 22 14:17:38 2022 +0000

    fix ut

commit ebb7580
Author: weizhichen <weizhichen@microsoft.com>
Date:   Thu Dec 22 13:17:34 2022 +0000

    support privateendpoint for blob csi driver
andyzhangx
andyzhangx approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/kind feat
pls also add release note in the PR description.

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The label(s) kind/feat cannot be applied, because the repository doesn't have them.

In response to this:

/lgtm
/kind feat
pls also add release note in the PR description.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2022
@andyzhangx
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind labels Dec 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 09debc3 into kubernetes-sigs:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@jwtty jwtty Awaiting requested review from jwtty

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cvvz @k8s-ci-robot @coveralls @andyzhangx