Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TimedCache.Get() for read-only resources #3107

Merged
merged 1 commit into from Jan 11, 2023
Merged

Use TimedCache.Get() for read-only resources #3107

merged 1 commit into from Jan 11, 2023

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jan 11, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cherry pick of #2949 against release-1.23: Use TimedCache.Get() for read-only resources

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: Use TimedCache.Get() for read-only resources

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023
@coveralls
Copy link

Coverage Status

Coverage: 80.57% (-0.01%) from 80.582% when pulling 0714715 on nilo19:fix/cherry-pick-2949-1.23 into 18062df on kubernetes-sigs:release-1.23.

@k8s-ci-robot k8s-ci-robot merged commit 252d63f into kubernetes-sigs:release-1.23 Jan 11, 2023
@nilo19 nilo19 deleted the fix/cherry-pick-2949-1.23 branch January 11, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilo19 @k8s-ci-robot @lzhecheng @coveralls