Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TimedCache.Get() for read-only resources #2949

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Use TimedCache.Get() for read-only resources #2949

merged 1 commit into from
Dec 15, 2022

Conversation

lzhecheng
Copy link
Contributor

Signed-off-by: Zhecheng Li zhechengli@microsoft.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@lzhecheng
Use TimedCache.Get() for read-only resources
192b8b1 
Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 15, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2022
@netlify
Copy link

netlify bot commented Dec 15, 2022 •
edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 192b8b1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/639ac8d44fc552000989887f

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/needs-kind size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 79.47% when pulling 192b8b1 on lzhecheng:fix-shallow-copy-dev into 0db5379 on kubernetes-sigs:master.

@lzhecheng lzhecheng changed the title [WIP][Not4Review] Use TimedCache.Get() for read-only resources Use TimedCache.Get() for read-only resources Dec 15, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2022
andyzhangx
andyzhangx approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andyzhangx,lzhecheng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx
Copy link
Member

/kind bug
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind labels Dec 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8b84d01 into kubernetes-sigs:master Dec 15, 2022
This was referenced Dec 15, 2022
Closed
Closed
@lzhecheng lzhecheng deleted the fix-shallow-copy-dev branch December 15, 2022 11:26
@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.26

@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.25

@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.24

@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.23

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 15, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: new pull request created: #2952

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: #2949 failed to apply on top of branch "release-1.25":

Applying: Use TimedCache.Get() for read-only resources
Using index info to reconstruct a base tree...
M	pkg/cache/azure_cache.go
M	pkg/provider/azure_vmss.go
M	pkg/provider/azure_vmss_cache.go
M	pkg/provider/azure_vmss_test.go
M	tests/e2e/network/node.go
M	tests/e2e/node/vmss.go
M	tests/e2e/utils/vmss_utils.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/utils/vmss_utils.go
Auto-merging tests/e2e/node/vmss.go
CONFLICT (content): Merge conflict in tests/e2e/node/vmss.go
Auto-merging tests/e2e/network/node.go
Auto-merging pkg/provider/azure_vmss_test.go
Auto-merging pkg/provider/azure_vmss_cache.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_cache.go
Auto-merging pkg/provider/azure_vmss.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss.go
Auto-merging pkg/cache/azure_cache.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use TimedCache.Get() for read-only resources
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: #2949 failed to apply on top of branch "release-1.24":

Applying: Use TimedCache.Get() for read-only resources
Using index info to reconstruct a base tree...
M	pkg/cache/azure_cache.go
M	pkg/provider/azure_vmss.go
M	pkg/provider/azure_vmss_cache.go
M	pkg/provider/azure_vmss_test.go
M	pkg/provider/azure_wrap.go
M	tests/e2e/network/node.go
M	tests/e2e/node/vmss.go
M	tests/e2e/utils/vmss_utils.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/utils/vmss_utils.go
Auto-merging tests/e2e/node/vmss.go
CONFLICT (content): Merge conflict in tests/e2e/node/vmss.go
Auto-merging tests/e2e/network/node.go
Auto-merging pkg/provider/azure_wrap.go
Auto-merging pkg/provider/azure_vmss_test.go
Auto-merging pkg/provider/azure_vmss_cache.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_cache.go
Auto-merging pkg/provider/azure_vmss.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss.go
Auto-merging pkg/cache/azure_cache.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use TimedCache.Get() for read-only resources
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: #2949 failed to apply on top of branch "release-1.23":

Applying: Use TimedCache.Get() for read-only resources
Using index info to reconstruct a base tree...
M	pkg/cache/azure_cache.go
M	pkg/provider/azure_vmss.go
M	pkg/provider/azure_vmss_cache.go
M	pkg/provider/azure_vmss_test.go
M	pkg/provider/azure_wrap.go
M	tests/e2e/network/node.go
M	tests/e2e/node/vmss.go
M	tests/e2e/utils/vmss_utils.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/utils/vmss_utils.go
Auto-merging tests/e2e/node/vmss.go
CONFLICT (content): Merge conflict in tests/e2e/node/vmss.go
Auto-merging tests/e2e/network/node.go
Auto-merging pkg/provider/azure_wrap.go
Auto-merging pkg/provider/azure_vmss_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_test.go
Auto-merging pkg/provider/azure_vmss_cache.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_cache.go
Auto-merging pkg/provider/azure_vmss.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss.go
Auto-merging pkg/cache/azure_cache.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use TimedCache.Get() for read-only resources
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jan 11, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@jwtty jwtty Awaiting requested review from jwtty

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lzhecheng @coveralls @k8s-ci-robot @andyzhangx @k8s-infra-cherrypick-robot