Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support data protection for blob csi driver #3115

Merged
merged 3 commits into from Jan 18, 2023
Merged

feat: support data protection for blob csi driver #3115

merged 3 commits into from Jan 18, 2023

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Jan 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

support data protection for blob csi driver

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

support data protection for blob csi driver

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @cvvz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 13, 2023
@netlify
Copy link

netlify bot commented Jan 13, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit ee5b942
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/63c76c3ea780590008f075de

@cvvz
Copy link
Member Author

cvvz commented Jan 13, 2023

@andyzhangx PTAL

@andyzhangx
Copy link
Member

@cvvz: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

@cvvz you could use git rebase upstream/master to rebase to master branch, then you won't have this warning message.

@cvvz cvvz force-pushed the support-data-protection-for-blob-csi-driver branch from 21369ab to dce5594 Compare January 13, 2023 10:44
andyzhangx
andyzhangx reviewed Jan 13, 2023
View reviewed changes
pkg/provider/azure_storageaccount.go Outdated Show resolved Hide resolved
pkg/provider/azure_storageaccount.go Outdated Show resolved Hide resolved
pkg/provider/azure_storageaccount.go Outdated Show resolved Hide resolved
andyzhangx
andyzhangx reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2023
@cvvz
Squashed commit of the following:
c877240 
commit 0162f0e5af55c034f40b83ab292fa39f2f759028
Merge: 7355e07 188ebdf
Author: weizhichen <weizhichen@microsoft.com>
Date:   Wed Jan 18 02:54:11 2023 +0000

    Merge branch 'master' of github.com:kubernetes-sigs/cloud-provider-azure into support-data-protection-for-blob-csi-driver

commit 7355e07
Author: weizhichen <weizhichen@microsoft.com>
Date:   Tue Jan 17 09:17:27 2023 +0000

    delete useless mockblobclient

commit 54bd7e6
Author: weizhichen <weizhichen@microsoft.com>
Date:   Tue Jan 17 08:57:40 2023 +0000

    do not search for storage accounts if data protection field not set

commit 1f26083
Author: weizhichen <weizhichen@microsoft.com>
Date:   Tue Jan 17 08:26:31 2023 +0000

    Revert "fix ut"

    This reverts commit 8b2e6b2.

commit f9a6092
Author: weizhichen <weizhichen@microsoft.com>
Date:   Tue Jan 17 08:24:05 2023 +0000

    revert delete storage account

commit ad83771
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Jan 13 12:20:36 2023 +0000

    fix

commit 8b2e6b2
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Jan 13 11:40:56 2023 +0000

    fix ut

commit 790ba4a
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Jan 13 11:28:43 2023 +0000

    typo

commit ecc8b67
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Jan 13 11:24:35 2023 +0000

    fix by code review

commit dce5594
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Jan 13 10:43:15 2023 +0000

    Squashed commit of the following:

    commit 21369ab
    Author: weizhichen <weizhichen@microsoft.com>
    Date:   Fri Jan 13 10:41:42 2023 +0000

        fix ut

    commit bec648e
    Author: weizhichen <weizhichen@microsoft.com>
    Date:   Fri Jan 13 10:33:49 2023 +0000

        fix lint

    commit 1acc7f0
    Author: weizhichen <weizhichen@microsoft.com>
    Date:   Fri Jan 13 10:06:55 2023 +0000

        change IsEnableBlobVersioning from bool to *bool

    commit 8aa7c2d
    Merge: d66726a 4448927
    Author: weizhichen <weizhichen@microsoft.com>
    Date:   Fri Jan 13 08:45:53 2023 +0000

        Merge branch 'account-search-fix2' of github.com:andyzhangx/cloud-provider-azure into support-data-protection-for-blob-csi-driver

    commit 4448927
    Author: andyzhangx <xiazhang@microsoft.com>
    Date:   Fri Jan 13 05:19:54 2023 +0000

        fix: make account search backward compatible

    commit d66726a
    Author: weizhichen <weizhichen@microsoft.com>
    Date:   Fri Jan 13 03:24:35 2023 +0000

        use %w to wrap error

    commit 388ee70
    Author: weizhichen <weizhichen@microsoft.com>
    Date:   Fri Jan 13 03:14:42 2023 +0000

        add mock

    commit e0a6674
    Author: weizhichen <weizhichen@microsoft.com>
    Date:   Fri Jan 13 03:07:38 2023 +0000

        feat: support data protection for blob csi driver
@cvvz cvvz force-pushed the support-data-protection-for-blob-csi-driver branch from 44e40ab to c877240 Compare January 18, 2023 02:58
@coveralls
Copy link

coveralls commented Jan 18, 2023 •
edited

Coverage Status

Coverage: 79.351% (-0.02%) from 79.373% when pulling ee5b942 on cvvz:support-data-protection-for-blob-csi-driver into 188ebdf on kubernetes-sigs:master.

@cvvz
Copy link
Member Author

cvvz commented Jan 18, 2023

/retest

andyzhangx
andyzhangx approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit fe29ec2 into kubernetes-sigs:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cvvz @k8s-ci-robot @andyzhangx @coveralls