feat: support workload identity #3378

cvvz · 2023-02-16T09:50:56Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: support workload identity

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: support workload identity

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

feat: support workload identity

netlify · 2023-02-16T09:51:00Z

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name	Link
🔨 Latest commit	`c62d043`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/644502f1a8e9c1000863badd
😎 Deploy Preview	https://deploy-preview-3378--kubernetes-sigs-cloud-provide-azure.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot · 2023-02-16T09:51:05Z

Hi @cvvz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2023-02-20T06:44:21Z

Coverage: 79.513% (-0.08%) from 79.589% when pulling 8318961 on cvvz:support-workload-identity into 6a378e6 on kubernetes-sigs:master.

MartinForReal · 2023-03-26T11:32:21Z

/kind feature

andyzhangx

/ok-to-test
does this PR require updating adal lib version?

cvvz · 2023-04-18T02:12:34Z

does this PR require updating adal lib version?

No, it's already the latest version

andyzhangx

it lgtm in general, thanks.

pkg/provider/azure.go

pkg/provider/config/azure_auth.go

andyzhangx

pls squash all commits, lgtm

commit 0244e89 Author: weizhichen <weizhichen@microsoft.com> Date: Sun Apr 23 02:52:46 2023 +0000 fix ut commit a2c27ff Author: weizhichen <weizhichen@microsoft.com> Date: Sun Apr 23 02:33:27 2023 +0000 add ut commit c84161d Author: weizhichen <weizhichen@microsoft.com> Date: Tue Apr 4 06:54:05 2023 +0000 upgrade adal to v0.9.23 commit 223fa07 Author: weizhichen <weizhichen@microsoft.com> Date: Wed Mar 1 01:16:40 2023 +0000 use jwtCallback to get the token commit 976b588 Author: weizhichen <weizhichen@microsoft.com> Date: Tue Feb 21 11:14:07 2023 +0000 fix commit 9380014 Author: weizhichen <weizhichen@microsoft.com> Date: Tue Feb 21 08:39:52 2023 +0000 fix commit a312af9 Author: weizhichen <weizhichen@microsoft.com> Date: Tue Feb 21 04:38:27 2023 +0000 fix commit 51b5ac7 Author: weizhichen <weizhichen@microsoft.com> Date: Fri Feb 17 00:20:45 2023 +0000 error wrapper commit c89b9a1 Author: weizhichen <weizhichen@microsoft.com> Date: Thu Feb 16 10:02:46 2023 +0000 fix commit 286e921 Author: weizhichen <weizhichen@microsoft.com> Date: Thu Feb 16 09:50:23 2023 +0000 support workload identity

andyzhangx

/lgtm

k8s-ci-robot · 2023-04-23T11:22:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 16, 2023

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2023

k8s-ci-robot requested review from andyzhangx and MartinForReal February 16, 2023 09:51

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2023

cvvz changed the title ~~[WIP]support workload identity~~ [WIP]feat: support workload identity Feb 16, 2023

cvvz force-pushed the support-workload-identity branch from 2988b45 to f2fcc1f Compare February 20, 2023 06:38

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 21, 2023

cvvz changed the title ~~[WIP]feat: support workload identity~~ feat: support workload identity Feb 24, 2023

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2023

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind labels Mar 26, 2023

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2023

cvvz force-pushed the support-workload-identity branch from 8bd5bd1 to 8318961 Compare April 4, 2023 06:57

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2023

andyzhangx reviewed Apr 17, 2023

View reviewed changes

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 17, 2023

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 17, 2023

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 19, 2023

andyzhangx reviewed Apr 19, 2023

View reviewed changes

pkg/provider/azure.go Show resolved Hide resolved

pkg/provider/config/azure_auth.go Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2023

cvvz force-pushed the support-workload-identity branch from 703de13 to a2c27ff Compare April 23, 2023 02:36

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2023

andyzhangx approved these changes Apr 23, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2023

cvvz force-pushed the support-workload-identity branch from 0244e89 to c62d043 Compare April 23, 2023 10:05

andyzhangx approved these changes Apr 23, 2023

View reviewed changes

k8s-ci-robot assigned andyzhangx Apr 23, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2023

k8s-ci-robot merged commit 8d912fa into kubernetes-sigs:master Apr 23, 2023
20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support workload identity #3378

feat: support workload identity #3378

cvvz commented Feb 16, 2023 •

edited by andyzhangx

netlify bot commented Feb 16, 2023 •

edited

k8s-ci-robot commented Feb 16, 2023

coveralls commented Feb 20, 2023 •

edited

MartinForReal commented Mar 26, 2023

andyzhangx left a comment

cvvz commented Apr 18, 2023

andyzhangx left a comment

andyzhangx left a comment

andyzhangx left a comment

k8s-ci-robot commented Apr 23, 2023

feat: support workload identity #3378

feat: support workload identity #3378

Conversation

cvvz commented Feb 16, 2023 • edited by andyzhangx

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

netlify bot commented Feb 16, 2023 • edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

k8s-ci-robot commented Feb 16, 2023

coveralls commented Feb 20, 2023 • edited

MartinForReal commented Mar 26, 2023

andyzhangx left a comment

Choose a reason for hiding this comment

cvvz commented Apr 18, 2023

andyzhangx left a comment

Choose a reason for hiding this comment

andyzhangx left a comment

Choose a reason for hiding this comment

andyzhangx left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 23, 2023

cvvz commented Feb 16, 2023 •

edited by andyzhangx

netlify bot commented Feb 16, 2023 •

edited

coveralls commented Feb 20, 2023 •

edited