Update nodeSelector and tolerations #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zhecheng Li <zhechengli@microsoft.com>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
k8s-ci-robot
added
approved
jwtty
reviewed
Feb 28, 2023
| @@ -2,10 +2,10 @@ apiVersion: v1 | |||
| entries: | |||
There was a problem hiding this comment.
Should we modify the existing index or create a new one?
There was a problem hiding this comment.
So far, we always use this one.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, lzhecheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This allows the
cloud-controller-managerto start on nodes withetcdtaints by default. Additionally, allows configuration for additional taints if the user chooses. Currently this customization is not available at all.Additionally allows configuration for
nodeSelector. This is similar to how thecloud-provider-awsconfigures their Helm chart. https://github.com/kubernetes/cloud-provider-aws/blob/5db84490841ebd1eede368d03eb03c27dc556233/charts/aws-cloud-controller-manager/values.yaml#L16Which issue(s) this PR fixes:
Fixes #
replace #3296
Special notes for your reviewer:
Thank you!
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: