[Helm] Update nodeSelector and tolerations

[atsai1220]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows the cloud-controller-manager to start on nodes with etcd taints by default. Additionally, allows configuration for additional taints if the user chooses. Currently this customization is not available at all.

Additionally allows configuration for nodeSelector. This is similar to how the cloud-provider-aws configures their Helm chart. https://github.com/kubernetes/cloud-provider-aws/blob/5db84490841ebd1eede368d03eb03c27dc556233/charts/aws-cloud-controller-manager/values.yaml#L16

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Thank you!

Does this PR introduce a user-facing change?

- Add tolerations in values for cloud-controller-manager in Helm chart
- Add nodeSelector in values for cloud-controller-manager in Helm chart

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atsai1220
Once this PR has been reviewed and has the lgtm label, please assign lzhecheng for approval by writing /assign @lzhecheng in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name	Link
🔨 Latest commit	79fbf0c
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/63e28f9ff6e03d0009ddb5b6

[k8s-ci-robot]

Hi @atsai1220. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andyzhangx]

/ok-to-test

[k8s-ci-robot]

@atsai1220: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cloud-provider-azure-check	79fbf0c	link	true	/test pull-cloud-provider-azure-check

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[atsai1220]

I'm not sure if I understand the failing test. The PR is adding the change for the values and templates of the Helm chart and the test seems like it's failing because there is a difference. @andyzhangx

[andyzhangx]

I'm not sure if I understand the failing test. The PR is adding the change for the values and templates of the Helm chart and the test seems like it's failing because there is a difference. @andyzhangx

@lzhecheng could you help? thanks.

[feiskyer]

LGTM, but the chart validation failed. I think the validation failure means the yaml after rendering is not same as latest version under repo/.

@lzhecheng could you confirm?

[lzhecheng]

Will check

[lzhecheng]

I think you missed one part: Update version in helm/cloud-provider-azure/Chart.yaml. Make it something like 1.26.4+20230210 and then make update-helm.

[lzhecheng]

Also, could you please update doc as well?

[lzhecheng]

@atsai1220 could you please update the PR? Thanks.

[atsai1220]

I'm not sure how to proceed. Could you provide some hand holding? Thank you.

[lzhecheng]

I'm not sure how to proceed. Could you provide some hand holding? Thank you.

My suggestion is to:

1. Rebase your PR
2. Update the version here to something like 1.26.4+20230215:

   cloud-provider-azure/helm/cloud-provider-azure/Chart.yaml

   Line 16 in 79fbf0c

   version: 1.26.4

3. Run make update-helm
4. Update the README doc about your changes

[lzhecheng]

/close
@atsai1220 I have merged your commit with another PR. Thank you for the effort!

[k8s-ci-robot]

@lzhecheng: Closed this PR.

In response to this:

/close
@atsai1220 I have merged your commit with another PR. Thank you for the effort!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.