fix: remove single vm from the cache instead of removing all vms of a… #3507
Conversation
… vmss when deleting a node from the cache
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
| return err | ||
| } | ||
| if exists { |
There was a problem hiding this comment.
I see master branch does not have such issue, so this is a specific fix on 1.23?
There was a problem hiding this comment.
this needs cherry-pick to 1.23-1.25.
| @@ -121,6 +122,20 @@ func TestVMSSVMCache(t *testing.T) { | |||
| err = ss.DeleteCacheForNode(vmName) | |||
| assert.NoError(t, err) | |||
|
|
|||
| // ensure only one vm is removed from the cache | |||
There was a problem hiding this comment.
thanks adding a test for this scenario!
There was a problem hiding this comment.
would you add this test into master branch @nilo19 I think master branch does not have this issue, but still needs a ut, thanks.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… vmss when deleting a node from the cache
What type of PR is this?
/kind bug
What this PR does / why we need it:
We remove all the vms of the vmss from the cache unexpectedly when deleting a node from the cache. This PR fixes it by only removing one single vm.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: